Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.compiler.ghcHEAD: 20190115 -> 20190601 #63001

Merged
merged 1 commit into from Jun 14, 2019
Merged

haskell.compiler.ghcHEAD: 20190115 -> 20190601 #63001

merged 1 commit into from Jun 14, 2019

Conversation

infinisil
Copy link
Member

@infinisil infinisil commented Jun 11, 2019 •
edited

Motivation for this change

I want a recent version for trying out https://gitlab.haskell.org/ghc/ghc/merge_requests/668

I'm not entirely sure on the version naming, I chose 8.9 because 8.8 is branched off already, and HEAD will once become 8.10

I included the patch not propagated in e001b99, because I still ran into haskell/haddock#900 when compiling the polysemy-zoo package, see commercialhaskell/stackage#4562 (comment). Not entirely sure why that patch doesn't appear to be in HEAD.

Since recent times, current ghcHEAD failed in nixpkgs, see https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.haskell.compiler.ghcHEAD.x86_64-linux, but this updated versions builds just fine.

Ping @peti @ryantm @deepfire @Ericson2314

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from peti and kosmikus June 11, 2019 23:01
@peti peti merged commit 61508b5 into NixOS:master Jun 14, 2019
@infinisil infinisil deleted the update/ghcHEAD branch June 14, 2019 17:46
@infinisil
Copy link
Member Author

infinisil commented Jun 28, 2019 •
edited

I'm not entirely sure on the version naming, I chose 8.9 because 8.8 is branched off already, and HEAD will once become 8.10

For future reference, 8.9 is indeed the official version and can be found here: https://gitlab.haskell.org/ghc/ghc/blob/ef6d9a50db115e296d2d9bec3e94c7369f1d504c/configure.ac#L16

@infinisil infinisil mentioned this pull request Jul 24, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@kosmikus kosmikus Awaiting requested review from kosmikus

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @peti