Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark flaky WebXR tests as slow #17277

Closed
wants to merge 1 commit into from

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 12, 2019

The chromium flakiness dashboard reports that these tests are flaky with
the longest running test taking 6 seconds (or always timing out), and
guidance appears to be that if it takes longer than two seconds on
release that it should be tagged as a "slow" test. Unfortunately,
local machines appear to have no problem with the tests. The first
step here is to see if increasing these test timeouts will cause these
tests to become less flaky.

Bug:961015
Change-Id: I17c2960f3420501b6ff7b381f72845d0432d3004
Reviewed-on: https://chromium-review.googlesource.com/1653603
WPT-Export-Revision: 6516bfd33cfb8fc0ae4e2946bb59efe5ebd2d766

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

The chromium flakiness dashboard reports that these tests are flaky with
the longest running test taking 6 seconds (or always timing out), and
guidance appears to be that if it takes longer than two seconds on
release that it should be tagged as a "slow" test.  Unfortunately,
local machines appear to have no problem with the tests.  The first
step here is to see if increasing these test timeouts will cause these
tests to become less flaky.

Bug:961015
Change-Id: I17c2960f3420501b6ff7b381f72845d0432d3004
@chromium-wpt-export-bot
Copy link
Collaborator Author

Close this PR because the Chromium CL has been abandoned.

@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1653603 branch July 8, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants