Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 67.0.1 -> 67.0.2 #63016

Merged
merged 1 commit into from
Jun 13, 2019
Merged

firefox: 67.0.1 -> 67.0.2 #63016

merged 1 commit into from
Jun 13, 2019
+399 −399

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 12, 2019

Motivation for this change

I believe this is updated by someone else regularly,
but noticed and was curious so submitting in case
it's useful. Simple the result of running the updateScript's
for these :).

https://www.mozilla.org/en-US/firefox/67.0.2/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dtzWill
firefox: 67.0.1 -> 67.0.2

Verified

This commit was signed with the committer’s verified signature. The key has expired.
alyssais Alyssa Ross
GPG key ID: F9DBED4859B271C0
Expired
Verified
Learn about vigilant mode
762f89d
@ofborg ofborg bot requested review from andir and edolstra June 12, 2019 05:08
@vcunat
Copy link
Member

vcunat commented Jun 12, 2019

I suppose noone has an idea why I'm repeatedly getting write error: stdout errors during build? (again but elsewhere) I don't seem to be exhausting any resources here.

@edolstra
Copy link
Member

@vcunat Is that on Hydra? Might be related to NixOS/nix#2878.

@vcunat
Copy link
Member

vcunat commented Jun 12, 2019 •
edited
Loading

No, it's just nix build invocation, happening both over NIX_REMOTE=ssh-ng:// and directly on that machine. EDIT: it's not a NixOS, so it's theoretically possible I haven't set up something ideally.

@andir
Copy link
Member

andir commented Jun 12, 2019 •
edited
Loading

It is an upstream issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1500436

Try building with at most 10 cores. Sometimes I have to go as low as 4. It really seems like a timing issues with some concurrent jobs.

The workaround mentioned in the bugzilla report (adding -v) didn't work for me when I tried.

@vcunat
Copy link
Member

vcunat commented Jun 12, 2019

I have a wild suspicion that when many processes write into a shared stream (stdout+stderr), they might sometimes get an EAGAIN or something... but generally this is so rare that much SW can't handle the error.

@andir
Copy link
Member

andir commented Jun 12, 2019

I had similar thought just never tried to debug it.. On hydra it seems to work just fine (most of the time) since the hosts either are busy enough or are not running a high amount of parallel builds.

I am wondering if we can just increase some amount of buffer space on the sockets (from within GNU make)?

vcunat
vcunat approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work fine on a quick test. The NEWS sound safe, and minor FF updates tend to be rather problem-free. Surprisingly I can't see any security fixes in there.

@andir
Copy link
Member

andir commented Jun 12, 2019

Surprisingly I can't see any security fixes in there.

They are lacking behind these days. Sometimes it takes them hours/days to publish them and then a bit more time to crosslink: https://www.mozilla.org/en-US/security/advisories/mfsa2019-16/

@vcunat
Copy link
Member

vcunat commented Jun 12, 2019 •
edited
Loading

I don't know... also I wonder why we haven't experienced this with other packages so far, right? For example, I was building the kernel on this 32-threaded machine (that was otherwise idle).

@vcunat vcunat mentioned this pull request Jun 12, 2019
Closed
10 tasks
@vcunat vcunat merged commit 762f89d into NixOS:master Jun 13, 2019
vcunat added a commit that referenced this pull request Jun 13, 2019
@vcunat
Merge #63016: firefox: 67.0.1 -> 67.0.2
3e54aaa
vcunat added a commit that referenced this pull request Jun 14, 2019
@vcunat
Merge #63016: firefox: 67.0.1 -> 67.0.2
421314a 
(cherry picked from commit 3e54aaa)
There are also some less sever security fixes:
https://www.mozilla.org/en-US/security/advisories/mfsa2019-16/
@vcunat
Copy link
Member

vcunat commented Jun 20, 2019

Upstream ticket has figured it out. One way that works for me is df6a6cc but there are various other approaches. It's just temporary anyway and should disappear after next nodejs release. WDYT?

@vcunat
Copy link
Member

vcunat commented Jul 1, 2019

For reference, this should now be OK on both branches: df1d27a, fe797e0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

@andir andir

@edolstra edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @vcunat @edolstra @andir