Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less: 530 -> 551 #63015

Merged
merged 1 commit into from Jun 15, 2019
Merged

less: 530 -> 551 #63015

merged 1 commit into from Jun 15, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 12, 2019

Motivation for this change

At long last! \o/

pname-ify while visiting.

http://greenwoodsoftware.com/less/news.551.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • ALLVM 馃槆
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
less: 530 -> 551
83065a5 
At long last! \o/

pname-ify while visiting.

http://greenwoodsoftware.com/less/news.551.html
@ofborg ofborg bot requested a review from edolstra June 12, 2019 04:59
@FRidh FRidh changed the base branch from master to staging June 12, 2019 07:19
@teto
Copy link
Member

teto commented Jun 12, 2019

I think something went wrong :p

@FRidh FRidh changed the base branch from staging to staging-next June 12, 2019 07:34
@FRidh FRidh changed the base branch from staging-next to staging June 12, 2019 07:34
@ivan
Copy link
Member

ivan commented Jun 12, 2019

I tested 551 on x86_64-linux and everything I use seems to work fine.

@FRidh FRidh merged commit 4f96316 into NixOS:staging Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @teto @ivan @FRidh