[css-flexbox] Make sure to layout overflow:auto elements #17270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1652198
branch
2 times, most recently
from
742b2c4
to
f760861
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1652198
branch
from
f760861
to
35235b7
Compare
For overflow: auto, we need to layout before running the flex algorithm if layout is dirty, so we can up-to-date scrollbar information, because scrollbar size is included in the intrinsic size. Bug: 972227 Change-Id: I58b5c0590575c5babc505b2927d8464f3f540775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652198 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#668199}
foolip
force-pushed
the
chromium-export-cl-1652198
branch
from
35235b7
to
6b932ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For overflow: auto, we need to layout before running the flex algorithm
if layout is dirty, so we can up-to-date scrollbar information, because
scrollbar size is included in the intrinsic size.
Bug: 972227
Change-Id: I58b5c0590575c5babc505b2927d8464f3f540775
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652198
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668199}