Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cli-helpers: 1.2.0 -> 1.2.1 #62989

Merged
merged 1 commit into from Jun 12, 2019
Merged

pythonPackages.cli-helpers: 1.2.0 -> 1.2.1 #62989

merged 1 commit into from Jun 12, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Noticed it was out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

$ nix path-info -Sh ./result
/nix/store/ixmsj9sdkr4yz6amixg2mvwmh6f6rwca-python3.7-cli_helpers-1.2.0 97.4M

$ nix path-info -Sh ./result
/nix/store/qkgy9i5chxvkw51j3xx9i2b6af5bm6ag-python3.7-cli_helpers-1.2.1 97.4M

@jonringer jonringer requested a review from FRidh as a code owner June 11, 2019 17:23
@ofborg ofborg bot requested a review from kalbasit June 11, 2019 17:37
@kalbasit
Copy link
Member

@GrahamcOfBorg build pythonPackages.cli-helpers

@kalbasit kalbasit merged commit e82f01d into NixOS:master Jun 12, 2019
@jonringer jonringer deleted the bump_cli_helpers branch June 12, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @kalbasit