Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bash completions for ZFS. #62986

Merged
merged 2 commits into from Jun 12, 2019
Merged

Add Bash completions for ZFS. #62986

merged 2 commits into from Jun 12, 2019

Conversation

caadar
Copy link
Contributor

@caadar caadar commented Jun 11, 2019 •
edited

Motivation for this change

zfs and zpool commands bash completion support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

marsam
marsam reviewed Jun 12, 2019
View reviewed changes
pkgs/os-specific/linux/zfs/default.nix Outdated
@@ -130,6 +130,9 @@ let

# Remove tests because they add a runtime dependency on gcc
rm -rf $out/share/zfs/zfs-tests

# Add Bash completions.
install -v -m444 -D contrib/bash_completion.d/zfs $out/etc/bash_completion.d/zfs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
install -v -m444 -D contrib/bash_completion.d/zfs $out/etc/bash_completion.d/zfs
install -v -m444 -D -t $out/share/bash-completion/completions contrib/bash_completion.d/zfs

the advantage of using $out/share/bash-completion/completions is that bash loads those on demand.
Besides that, LGTM

@matthewbauer matthewbauer merged commit 57301d9 into NixOS:master Jun 12, 2019
@marsam marsam mentioned this pull request Jun 12, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@caadar @marsam @matthewbauer @Janik-Haag