Revert "Ignore lint failures until we import a rev with them fixed" #17289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts #13396. These exact lines are also in the "Duplicate filename where there's no actual merging" section of the file. The change came from https://hg.mozilla.org/mozilla-central/rev/f23487d9ab99d486fe3ab7f261e4d4e0bf1172ae where those lines were present, although they were present in WPT when that change was upstreamed.
foolip
added a commit
that referenced
this pull request
Jun 12, 2019
See also #17289 which was discovered when preparing this change.
chromium-wpt-export-bot
pushed a commit
that referenced
this pull request
Jun 12, 2019
See also #17289 which was discovered when preparing this change.
Ms2ger
approved these changes
Jun 17, 2019
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 19, 2019
…isplay lock) for NG fieldset algo, a=testonly Automatic update from web-platform-tests NG/DL: Implement size containment (and display lock) for NG fieldset algo This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660866} -- Add colliding ref names to lint.whitelist See also web-platform-tests/wpt#17289 which was discovered when preparing this change. -- wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d wpt-pr: 16858
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Jun 19, 2019
…isplay lock) for NG fieldset algo, a=testonly Automatic update from web-platform-tests NG/DL: Implement size containment (and display lock) for NG fieldset algo This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtr@chromium.org, ikilpatrick@chromium.org, mstensho@chromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660866} -- Add colliding ref names to lint.whitelist See also web-platform-tests/wpt#17289 which was discovered when preparing this change. -- wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d wpt-pr: 16858
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
See also #17289 which was discovered when preparing this change.
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
…17289) This reverts #13396. These exact lines are also in the "Duplicate filename where there's no actual merging" section of the file. The change came from https://hg.mozilla.org/mozilla-central/rev/f23487d9ab99d486fe3ab7f261e4d4e0bf1172ae where those lines were present, although they were present in WPT when that change was upstreamed.
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 4, 2019
…isplay lock) for NG fieldset algo, a=testonly Automatic update from web-platform-tests NG/DL: Implement size containment (and display lock) for NG fieldset algo This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtrchromium.org, ikilpatrickchromium.org, mstenshochromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: vmpstr <vmpstrchromium.org> Cr-Commit-Position: refs/heads/master{#660866} -- Add colliding ref names to lint.whitelist See also web-platform-tests/wpt#17289 which was discovered when preparing this change. -- wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d wpt-pr: 16858 UltraBlame original commit: 9d67939c11cbbc1f5a6f90311dcf93cc01447720
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 4, 2019
…isplay lock) for NG fieldset algo, a=testonly Automatic update from web-platform-tests NG/DL: Implement size containment (and display lock) for NG fieldset algo This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtrchromium.org, ikilpatrickchromium.org, mstenshochromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: vmpstr <vmpstrchromium.org> Cr-Commit-Position: refs/heads/master{#660866} -- Add colliding ref names to lint.whitelist See also web-platform-tests/wpt#17289 which was discovered when preparing this change. -- wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d wpt-pr: 16858 UltraBlame original commit: 9d67939c11cbbc1f5a6f90311dcf93cc01447720
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 4, 2019
…isplay lock) for NG fieldset algo, a=testonly Automatic update from web-platform-tests NG/DL: Implement size containment (and display lock) for NG fieldset algo This patch adds size containment implementation for fieldsets in LayoutNG. Tested with LayoutNGFieldset feature flag. Along with the new tests, external/wpt/css/css-contain/contain-size-fieldset-001.html and external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-fieldset-001.html are also passing. R=chrishtrchromium.org, ikilpatrickchromium.org, mstenshochromium.org Bug: 958975 Change-Id: I5e735adc65ed9450f84e4c1ab68cba69e3fd85ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613844 Reviewed-by: Morten Stenshorne <mstenshochromium.org> Commit-Queue: vmpstr <vmpstrchromium.org> Cr-Commit-Position: refs/heads/master{#660866} -- Add colliding ref names to lint.whitelist See also web-platform-tests/wpt#17289 which was discovered when preparing this change. -- wp5At-commits: 2d4a450b602564b5c7461c76e281552b60363602, 677d31b5fbbcfe9d3f7628a9b73c4a6066bbe76d wpt-pr: 16858 UltraBlame original commit: 9d67939c11cbbc1f5a6f90311dcf93cc01447720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #13396.
These exact lines are also in the "Duplicate filename where there's no
actual merging" section of the file.
The change came from https://hg.mozilla.org/mozilla-central/rev/f23487d9ab99d486fe3ab7f261e4d4e0bf1172ae
where those lines were present, although they were present in WPT when
that change was upstreamed.