Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flashplayer: 32.0.0.192 -> 32.0.0.207 [Critical security fixes] #63030

Merged
merged 1 commit into from Jun 12, 2019

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jun 12, 2019

Motivation for this change
  • Critical security fixes
  • Other bug fixes

https://helpx.adobe.com/security/products/flash-player/apsb19-30.html
https://helpx.adobe.com/flash-player/release-note/fp_32_air_32_release_notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Assured whether relevant documentation is up to date

  • Fits CONTRIBUTING.md.

  • Built packages

    • nix-env -i -f . -A pkgs.flashplayer
    • nix-build -I nixpkgs=. -A pkgsi686Linux.flashplayer
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).pkgsi686Linux.flashplayer.override { debug = true; }"
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone
    • nix-build -I nixpkgs=. -A pkgs.flashplayer-standalone-debugger
    • nix-build -I nixpkgs=. -E "(import <nixpkgs> {}).chromium.override { enablePepperFlash = true; }"
  • Played those videos with Firefox (x86_64) and Chromium (x86_64)


@ivan
Copy link
Member

ivan commented Jun 12, 2019

@GrahamcOfBorg build flashplayer-standalone-debugger flashplayer flashplayer-standalone

@fpletz fpletz merged commit 7bf0c39 into NixOS:master Jun 12, 2019
@ivan
Copy link
Member

ivan commented Jun 12, 2019

Thanks, could you also submit a backport for 19.03?

@fpletz
Copy link
Member

fpletz commented Jun 12, 2019

Already on it. :)

@fpletz
Copy link
Member

fpletz commented Jun 12, 2019

Pushed to 19.03 as f749923.

@veprbl veprbl added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants