Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelMergerNode supports active processing #17273

Merged
merged 1 commit into from Jun 12, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 11, 2019

When a ChannelMergerNode is not actively processing its inputs, the
number of channels in its output is one, instead of the number of
inputs.

Just need to disable outputs when the node is created. Connections to
the node will adjust the number of channels appripriately, and when
inputs are no longer actively processing, the number of output
channels becomes one, as required.

Bug: 925046
Test: the-channelmergernode-interface/active-processing.https.html
Change-Id: I08e5fd2fe9c99b75af177eb85212162ecf39efd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645478
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668159}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

When a ChannelMergerNode is not actively processing its inputs, the
number of channels in its output is one, instead of the number of
inputs.

Just need to disable outputs when the node is created.  Connections to
the node will adjust the number of channels appripriately, and when
inputs are no longer actively processing, the number of output
channels becomes one, as required.

Bug: 925046
Test: the-channelmergernode-interface/active-processing.https.html
Change-Id: I08e5fd2fe9c99b75af177eb85212162ecf39efd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645478
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668159}
@foolip foolip force-pushed the chromium-export-cl-1645478 branch from f1ab1cb to 4fe9f47 Compare June 12, 2019 10:22
@chromium-wpt-export-bot chromium-wpt-export-bot merged commit bfb0371 into master Jun 12, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot deleted the chromium-export-cl-1645478 branch June 12, 2019 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants