Make etc/profile.d/nix.sh idempotent #2940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arguably this file isn't intended to be idempotent since it should only sourced once (by a login shell). |
Repeatedly loading this file currently creates duplicate entries in PATH, NIX_PATH, and sometimes MANPATH. Testing before inserting prevents this.
burke
force-pushed
the
idempotent-nix-profile-sh
branch
from
93c7518
to
89d1679
Compare
|
(I've rebased on the current master now) If you don't want to merge this, I can just continue with my workaround, but it strikes me as good practice for scripts like this to act idempotently even when it's not really intended for them to be sourced multiple times (tooling developers in my org end up evaluating it when we switch branches and reload various shell integrations). One other thing that strikes me, looking at this file, is that it might be beneficial to unconditionally set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly loading this file currently creates duplicate entries in
PATH,NIX_PATH, and sometimesMANPATH. Testing before inserting prevents this.