Update lilypond* #62937
Update lilypond* #62937
Conversation
|
Hm, nice |
|
@GrahamcOfBorg build lilypond |
|
Any comments on how it uses |
|
I added it blindly because the logs suggested it, but it looks like it's used when building documentation. http://lilypond.org/doc/v2.19/Documentation/contributor/requirements-for-building-documentation We could make it optional with the default Edit: I've removed it. Maybe later we should add an argument like |
|
@GrahamcOfBorg build lilypond |
|
@GrahamcOfBorg build lilypond-unstable |
- fetchurl -> fetchgit - urwfonts -> ghostscript/share/fonts - Add me as maintainer
- fetchurl -> fetchgit - urw-fonts -> ghostscript/share/fonts - overrideDerivation -> overrideAttrs
- Use symlinkJoin - Cleanup quoting - Inherit meta and version from lilypond
- Install to lilypond fonts dir - Use lilypond-unstable by default
|
@GrahamcOfBorg build lilypond-with-fonts |
|
🎉 Thanks, @7c6f434c! Let me know if you have any on how to improve the self: super {
lilypond-with-improviso = super.lilypond-with-fonts.override {
fonts = with super.openlilylib-fonts; [ improviso ];
};
}with this: self: super {
lilypond-with-improviso = super.lilypond-with-fonts [ improviso ];
}...but I don't know how to support it. It seems like |
|
```nix
self: super {
lilypond-with-improviso = super.lilypond-with-fonts [ improviso ];
}
```
This is probably impossible as `improviso` has to be imported from its scope…
|
|
Ah, I see. It actually works like this: self: super {
my-idris = super.idrisPackages.with-packages (with super.idrisPackages; [ contrib pruviloj ]);
}So maybe this would be a feasible goal: self: super {
lilypond-with-improviso = super.lilypond-with-fonts (with super.openlilylib-fonts; [ improviso ]);
} |
|
So maybe this would be a feasible goal:
```nix
self: super {
lilypond-with-improviso = super.lilypond-with-fonts (with super.openlilylib-fonts; [ improviso ]);
}
```
This is basically what
```nix
lilypond-with-fonts = fonts: callPackage … { inherit fonts; };
```
does, I think?
|
|
|
||
| install -m755 -d $fontsdir/otf | ||
| install -m755 -d $fontsdir/svg | ||
| paths = [ lilypond ]; |
There was a problem hiding this comment.
I forgot ++ fonts here...
Motivation for this change
fetchgitUsersyncinlilypondbuildlilypond(and by extensionlilypond-unstable)lilypondbroken on darwin (segfault on my machine, been failing on hydra awhile)lilypond-stablefrom2.19.65to2.19.83overrideAttrstooverrideDerivationinlilypond-unstableghostscriptinstead of pointing to a nonexistent urw-fonts repolilyponddatadirThings done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)