Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/release-notes: document changed CargoSha256 hashes #62935

Merged
merged 1 commit into from Jun 10, 2019
Merged

nixos/release-notes: document changed CargoSha256 hashes #62935

merged 1 commit into from Jun 10, 2019

Conversation

danieldk
Copy link
Contributor

Motivation for this change

cargoSha256 hashes change as result of changes in cargo-vendor, as
discussed in #60668.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
nixos/release-notes: document changed CargoSha256 hashes
b5b5648 
cargoSha256 hashes change as result of changes in cargo-vendor, as
discussed in NixOS#60668.
@Ma27 Ma27 merged commit 338a6e3 into NixOS:master Jun 10, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 10, 2019

@danieldk thanks!

@Ma27 Ma27 mentioned this pull request Jun 10, 2019
Closed
@danieldk danieldk deleted the cargo-vendor-change-doc branch June 10, 2019 09:11
@lopsided98
Copy link
Contributor

Somehow, this got merged incorrectly and now looks like this: https://github.com/NixOS/nixpkgs/blob/master/nixos/doc/manual/release-notes/rl-1909.xml#L264

@Ma27
Copy link
Member

Ma27 commented Jun 23, 2019

Oh, that shouldn't happen. It seems as this has been introduced by the following merge: 7953a65#diff-9c1b6e8f980c1d730ebfc9306a45ead9

Unfortunately I'm currently busy with other stuff, do you have sufficient time to file a patch that fixes this? :)

@lopsided98 lopsided98 mentioned this pull request Jun 29, 2019
Merged
10 tasks
@anderslundstedt anderslundstedt mentioned this pull request Aug 6, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @Ma27 @lopsided98