Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parity: 2.4.6 -> 2.4.8, parity-beta: 2.5.1 -> 2.5.3 #63011

Merged
merged 3 commits into from Jun 27, 2019
Merged

parity: 2.4.6 -> 2.4.8, parity-beta: 2.5.1 -> 2.5.3 #63011

merged 3 commits into from Jun 27, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 12, 2019 •
edited

Motivation for this change

Update parity and parity-beta to the latest release.
https://github.com/paritytech/parity-ethereum/releases/tag/v2.4.8
https://github.com/paritytech/parity-ethereum/releases/tag/v2.5.3

cc @akru to review. Thank you!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd xrelkd force-pushed the update/parity branch 3 times, most recently from 1509b22 to 4f63cc3 Compare June 12, 2019 08:12
mmahut
mmahut approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 26, 2019

Hi @marsam
I think that this PR gets stuck.
Could you review this PR and call @GrahamcOfBorg to build parity and parity-beta ?
Thank you!!

@xrelkd xrelkd changed the title parity: 2.4.6 -> 2.4.7, parity-beta: 2.5.1 -> 2.5.2 parity: 2.4.6 -> 2.4.8, parity-beta: 2.5.1 -> 2.5.3 Jun 26, 2019
@akru
Copy link
Contributor

akru commented Jun 26, 2019

@GrahamcOfBorg build parity parity-beta

@marsam
Copy link
Contributor

marsam commented Jun 27, 2019 •
edited

it fails when I try to build it
parity https://gist.github.com/marsam/f978e47eb9900600daadd02b22f5b80d
parity-beta https://gist.github.com/marsam/6f797950de52d1f1291ccc574f9eed59
@xrelkd can you build them?
@GrahamcOfBorg build parity parity-beta

@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 27, 2019

@marsam Thanks for the review.
I could build partiy and parity-beta with nix-build -A parity and nix-build -A parity-beta.

user@local:~ ➔ ./result/bin/parity --version
Parity Ethereum
  version Parity-Ethereum/v2.4.8-stable/x86_64-linux-gnu/rustc1.34.2
Copyright 2015-2019 Parity Technologies (UK) Ltd.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

By Wood/Paronyan/Kotewicz/Drwięga/Volf
   Habermeier/Czaban/Greeff/Gotchac/Redmann

@marsam marsam merged commit c79d8f7 into NixOS:master Jun 27, 2019
@marsam
Copy link
Contributor

marsam commented Jun 27, 2019

I trust you :), it must be something on my side

@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 27, 2019

@akru @marsam @mmahut Thank you!

@xrelkd xrelkd deleted the update/parity branch June 27, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xrelkd @akru @marsam @mmahut