Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tflint: init at 0.8.3 #63012

Merged
merged 1 commit into from Jun 17, 2019
Merged

tflint: init at 0.8.3 #63012

merged 1 commit into from Jun 17, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jun 12, 2019

Motivation for this change

Add https://github.com/wata727/tflint

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 12, 2019 03:30
@kalbasit
Copy link
Member

@GrahamcOfBorg build tflint

@flokli
Copy link
Contributor

flokli commented Jun 16, 2019

@marsam given tflint seems to reach out to various terraform providers to determine whether a configuration is valid, how does it discover those?

@kalbasit
Copy link
Member

trying Darin again.

@GrahamcOfBorg build tflint

@kalbasit kalbasit merged commit 239de52 into NixOS:master Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @kalbasit @flokli