-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
infix: init at 1.2 #63010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infix: init at 1.2 #63010
Conversation
sha256 = "a1bfdcf875bc072f41e426d0673f2e3017750743bb90cc725fffb292eb09648c"; | ||
}; | ||
|
||
doCheck = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
doCheck = false; # tests written in Python 2; library compiles and runs properly otherwise. | ||
buildInputs = with pkgs; [ glibcLocales ]; | ||
propagatedBuildInputs = with pythonPackages; [ pytest coverage ]; | ||
preConfigure = '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed anymore
sha256 = "06136f03d5b361718b8d0d234042f7b2f203910d8568f63df2f866b547b3d4b9"; | ||
}; | ||
|
||
doCheck = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed
@@ -0,0 +1,33 @@ | |||
{ pkgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't pass in pkgs
. Pass in actual packages instead
@@ -0,0 +1,33 @@ | |||
{ pkgs | |||
, lib | |||
, pythonPackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't pass in pythonPackages
. Pass in actual packages instead.
@@ -0,0 +1,29 @@ | |||
{ lib | |||
, pkgs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as before
@@ -0,0 +1,29 @@ | |||
{ lib | |||
, pkgs | |||
, pythonPackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as before
Motivation for this change
New package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)