Fix: Various reliability and correctness improvements to MIDI on Windows #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordAro
reviewed
Jun 10, 2019
| @@ -35,14 +35,14 @@ static struct { | |||
| CRITICAL_SECTION lock; ///< synchronization for playback status fields | |||
|
|
|||
| bool playing; ///< flag indicating that playback is active | |||
| bool do_start; ///< flag for starting playback of next_file at next opportunity | |||
| int do_start; ///< flag for starting playback of next_file at next opportunity | |||
There was a problem hiding this comment.
The members would be StartStep1, StartStep2, StartStep3, etc., I don't see a way to make a meaningful enum of this.
Ideally MidiFile would scan for various different init sequences in a file, and if a known sequence is found then leave it, otherwise prepend an init sequence (GM reset + reverb settings) to the data so the driver doesn't need to do anything difficult. I have more plans for improving music support (also past MIDI) and this idea is probably better left for then.
michicc
reviewed
Jun 10, 2019
michicc
requested changes
Jul 1, 2019
michicc
approved these changes
Jul 4, 2019
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jul 7, 2019
michicc
added
the
backport requested
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jul 7, 2019
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jul 7, 2019
michicc
pushed a commit
to michicc/OpenTTD
that referenced
this pull request
Jul 7, 2019
michicc
pushed a commit
that referenced
this pull request
Jul 7, 2019
michicc
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I probably should try to split this into multiple commits.
The last point is tested on a Roland and a Yamaha synth, both behave as expected.
Should fix #7438 (by resetting correctly between tracks)