Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm not sure what to do about this one - alongside the up-to-date version of
pythonPackages.cmd2
we also havepythonPackages.cmd2_8
(0.8.0). It seems we've been keeping this for python 2.7 (see commit message 65b15ba), and indeedcmd2
actually supports py2.7 right up to 0.8.6 (https://github.com/python-cmd2/cmd2/blob/master/CHANGELOG.md#085-april-15-2018).But unfortunately the recent bump of
pyparsing
from 2.3.0 to 2.3.1 (c78bf91) broke even 0.8.6's tests (probably because of https://github.com/pyparsing/pyparsing/blob/2809cc975277e5b8c9160e1bac903d414eab305d/CHANGES#L100). So we'd either have to disable more tests than I'd like or maintain an old version ofpyparsing
too. And seeing as there don't actually seem to be any in-tree reverse dependencies ofcmd2_8
, it seems most sensible to just remove it - we can't go on offering a whole parallel package selection for 2.7...Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)