[Gecko Bug 1524431] Part 2 - Check IsBidiSplittable() before processing the ancestor frames. #17275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 11, 2019
|
(Needs a rebase to pass CI, due to #17286. Sorry!) |
The idea is to check IsBidiSplittable() in more places to prevent fixed continuations created by column-span from becoming fluid ones. Differential Revision: https://phabricator.services.mozilla.com/D34093 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1524431 gecko-commit: 6f0a648c3d83086a400c87067e6fd6e584207ae6 gecko-integration-branch: autoland gecko-reviewers: jfkthame
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to check IsBidiSplittable() in more places to prevent fixed
continuations created by column-span from becoming fluid ones.
Differential Revision: https://phabricator.services.mozilla.com/D34093
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1524431
gecko-commit: 6f0a648c3d83086a400c87067e6fd6e584207ae6
gecko-integration-branch: autoland
gecko-reviewers: jfkthame