-
-
Notifications
You must be signed in to change notification settings - Fork 15.6k
pythonPackages.pytest-watch: init at 4.2.0 #63007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for taking interest in python packaging in nixpkgs.
There's a couple general issues here that need fixing.
- correct commit msg
They need to be formatted like pythonPackages.$package_name
- don't use
pythonPackages
in python module expressions
all pythonPackages.$pkgs
are in scope so you should reference them formally.
- don't propagate
pytest
We have multiple versions of pytest
in nixpkgs.
So it makes it very easy to use multiple versions if this is just in buildInputs
.
- enable
pytest-watch
tests
See #63007 (comment)
Other minor comments follow.
This looks to already be part of #63004 so I'll favor adding that package in this pr since I've reviewed it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to fix
- don't use
pythonPackages
in python module expressions
allpythonPackages.$pkgs
are in scope so you should reference them formally.
Also can you revert partially 97752d7?
So checkPhase
is like in comment #63007 (comment)
checkInputs = [ pytest ];
checkPhase = ''
pytest test
'';
Doing ${pytest}/bin/pytest
isn't needed.
Lastly see #63007 (comment)
Done. I'm going to push the changes as you requested, but I can't build locally without $ nix-build -A pythonPackages.pytest-watch
error: undefined variable 'pytest' at /home/dmvianna/sandbox/nixes/nixpkgs/pkgs/development/python-modules/pytest-watch/default.nix:20:19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same remarks as in #63010
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Co-Authored-By: worldofpeace <worldofpeace@protonmail.ch>
Motivation for this change
New package.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)