Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES6 modules] Fix crash when dynamic import from an inactive browsing context #17279

Merged
merged 1 commit into from Jun 18, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jun 12, 2019

Bug: 972960, 961674
Change-Id: Iff5c464dcc5227f211462f0e1b70c938fab452c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654370
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669989}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1654370 branch 2 times, most recently from 4e4d632 to 886623a Compare June 13, 2019 05:24
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title [ES6 modules] Throw exception from dynamic import from inactive browsing context [ES6 modules] Fix crash when dynamic import from an inactive browsing context Jun 13, 2019
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1654370 branch 2 times, most recently from 0e7c915 to f3e77c3 Compare June 14, 2019 06:42
… context

Bug: 972960, 961674
Change-Id: Iff5c464dcc5227f211462f0e1b70c938fab452c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654370
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#669989}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants