[LayoutNG] Fix float + nbsp to create a break opportunity #17281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 12, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1653171
branch
2 times, most recently
from
930b783
to
970c3e0
Compare
Floats should create break opportunities, and |NGLineBreaker::Rewind()| assumes this. However, |nbsp| after floats suppressed the break opportunity, which caused NGLineBreaker to loop infinitely under certain conditions. This patch fixes floats to allow break after them. Note the new behavior is the same as Gecko. Bug: 972421 Change-Id: Ie8c1d7927c5c282078a20f90941398149ea702a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653171 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#668681}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1653171
branch
from
970c3e0
to
ab2524a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floats should create break opportunities, and
|NGLineBreaker::Rewind()| assumes this. However, |nbsp|
after floats suppressed the break opportunity, which caused
NGLineBreaker to loop infinitely under certain conditions.
This patch fixes floats to allow break after them.
Note the new behavior is the same as Gecko.
Bug: 972421
Change-Id: Ie8c1d7927c5c282078a20f90941398149ea702a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653171
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#668681}