Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

midisheetmusic: always bring timidity dependency #63024

Merged
merged 1 commit into from Jul 18, 2019
Merged

midisheetmusic: always bring timidity dependency #63024

merged 1 commit into from Jul 18, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2019 •
edited by FRidh

Motivation for this change

Currently after system upgrade, if midisheetmusic is got from binary cache, it shows The Timidity MIDI player is not installed error. This is because timidity is not present in nix store at user side.

Instead of #53813 cc @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jun 28, 2019 •
edited by ghost

To test this

  1. Remove midisheetmusic and timidity with nix-store --delete
  2. Install this change from cachix and ensure that timidity is added to store along with midisheetmusic
    sudo nix-store -r /nix/store/lqanwh2h8rmkw698rfaa68hzza3ny1vb-midisheetmusic-2.6 --option trusted-public-keys 'gnidorah.cachix.org-1:BoUbQYpEN0+l/vMirtcHnQauOyfX+WKlUJfiUdWhGmo=' --option trusted-substituters 'https://cach e.nixos.org/ https://gnidorah.cachix.org/' --option binary-caches 'https://cache.nixos.org/ https://gnidorah.cachix.org/''

@FRidh
Copy link
Member

FRidh commented Jul 10, 2019

Build propagation is not for ensuring a dependency is available during run-time. If you need it during run-time, a reference needs to exist. This can exist because your project is build against it, or because you explicitly include it in a file such as a wrapper.

@ghost
Copy link
Author

ghost commented Jul 10, 2019

@FRidh Thanks for explanation! I've added timidity to wrapper instead

@FRidh
Copy link
Member

FRidh commented Jul 12, 2019

@GrahamcOfBorg build midisheetmusic

@ghost
Copy link
Author

ghost commented Jul 15, 2019

@FRidh Merge please! 😃

@FRidh FRidh merged commit 18183e8 into NixOS:master Jul 18, 2019
@ghost
Copy link
Author

ghost commented Jul 18, 2019

@FRidh thank you!

@ghost ghost deleted the midisheetmusic branch July 18, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh