Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: 0.1.0 -> 20190521 #62953

Merged
merged 1 commit into from Aug 14, 2019
Merged

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 10, 2019

Motivation for this change

Update to latest unstable. The 0.1.0 version used by the previous version of the package was incorrect, as that's just a placeholder that Cargo adds by default.

Spoke to one of the maintainers and they've made no releases to date, and he mentioned that now would be a good time to package since things are relatively stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build wasmtime

@matthewbauer matthewbauer merged commit 81bddd6 into NixOS:master Aug 14, 2019
@asymmetric asymmetric deleted the wasmtime-update branch August 14, 2019 14:35
@nomeata
Copy link
Contributor

nomeata commented Sep 21, 2019

I found that this version regresses in how wasmtime handles trapping code. Before it said:

error while processing main module _out/issue36.wasm: Instantiation error: Trap occurred while invoking start function: wasm trap at 0x___:

and afterwards it said

thread 'main' panicked at 'already borrowed: BorrowMutError', src/libcore/result.rs:999:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

I guess I shouldn’t report this bug here, but maybe someone would mind bumping wasmtime to a newer version so that I can see if these problems disappear?

Also, the darwin build fails, but that is not a regression over the previous version bump here.

@nomeata
Copy link
Contributor

nomeata commented Sep 30, 2019

Latest wasmtime master has fixed this:

error: failed to process main module `_out/issue36.wasm`
    caused by: Instantiation error: Trap occurred while invoking start function: wasm trap: unreachable, source location: @2eb9

I will see if I upgrade nixpkgs and maybe provide a patch.

@nomeata
Copy link
Contributor

nomeata commented Oct 17, 2019

It has, but the darwin build still fails

  = note: Undefined symbols for architecture x86_64:
            "_utimensat", referenced from:
                wasi_common::sys::unix::hostcalls_impl::fs::path_filestat_set_times::h9202e1bd89d768f0 in wasi_common-373cfd6ebb1545cd.wasi_common.av4m7sfr-cgu.5.rcgu.o
            "_futimens", referenced from:
                wasi_common::sys::unix::hostcalls_impl::fs::fd_filestat_set_times::hd2eb8b4bd780a131 in wasi_common-373cfd6ebb1545cd.wasi_common.av4m7sfr-cgu.5.rcgu.o
          ld: symbol(s) not found for architecture x86_64
          clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

@nomeata
Copy link
Contributor

nomeata commented Oct 18, 2019

I will see if I upgrade nixpkgs and maybe provide a patch.

#71316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants