Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amp: init at 2019.06.11 #62978

Merged
merged 1 commit into from Jun 20, 2019
Merged

amp: init at 2019.06.11 #62978

merged 1 commit into from Jun 20, 2019

Conversation

sbourdeauducq
Copy link
Contributor

Motivation for this change

Add a package for a nice text editor.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Jun 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick review with a few small things I noticed.

pkgs/applications/editors/amp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/amp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/amp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/amp/default.nix Outdated Show resolved Hide resolved
pkgs/applications/editors/amp/default.nix Outdated Show resolved Hide resolved
@sbourdeauducq
Copy link
Contributor Author

OK, except for the version number everything is resolved.

@sbourdeauducq sbourdeauducq force-pushed the for-upstream branch 2 times, most recently from ff2d808 to c4efd1a Compare June 12, 2019 00:37
@sbourdeauducq
Copy link
Contributor Author

All done

aanderse
aanderse approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse
Copy link
Member

@GrahamcOfBorg build amp

@aanderse
Copy link
Member

@sbourdeauducq Sorry I realized I missed something! You need to add platforms to meta.

@sbourdeauducq
Copy link
Contributor Author

AFAICT it should be rather platform-independent. It's just a regular Rust app...
There are several other Rust application packages that don't have platforms and I'm not sure if they should.

@srhb
Copy link
Contributor

srhb commented Jun 13, 2019

@sbourdeauducq I would say they should indeed, eg. platforms.all or platforms.unix depending. :)

@sbourdeauducq
Copy link
Contributor Author

Ok.

@aanderse
Copy link
Member

@GrahamcOfBorg build amp

@aanderse aanderse merged commit 6675589 into NixOS:master Jun 20, 2019
@aanderse
Copy link
Member

@sbourdeauducq thank you very much for your contribution to nixpkgs! This looks like a really cool editor 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbourdeauducq @aanderse @srhb