New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
matrix-synapse: 0.99.5.2 -> 1.0.0 #62990
Conversation
This might come with need of changes to the NixOS module, there is at least a new What do you think about this question? |
Oh and: @GrahamcOfBorg build nixosTests.matrix-synapse |
To be honest, I'm not really fond of NixOS/rfcs#42. But you're right about the new options. I'll check for new options and add those. |
You may want to self-nominate on NixOS/rfcs#42, this would help you discuss it properly :) |
I don't believe it's necessary to add the new options; I think there are already many options we don't expose, and one more shouldn't block updating. |
2478493
to
557c586
Compare
@Ralith Exposing that many options, suggesting we are exposing them all, yet not actually exposing them all is in itself an issue. Totally agree that doesn't necessarily need to be addressed in this PR, just wanted to start the discussion someplace :) |
Wouldn't it be easier to expose a minimal set of options and merge the rest using I did something similar in the mxisd module: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/services/networking/mxisd.nix It works quite well. Whenever mxisd got an update I only changed my |
I'm on board with reducing the complexity of the module, but that's a long-term matter. |
@mguentner Sounds like something compatible with the current state of RFC42, which you may want to comment over there so that it gets an additional data point :) |
Motivation for this change
https://matrix.org/blog/2019/06/11/synapse-1-0-0-released
https://matrix.org/blog/2019/06/11/introducing-matrix-1-0-and-the-matrix-org-foundation
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)