plan9port: build everything on Darwin #62992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build plan9port |
A commit in 2014 (see NixOS#2266) disabled building parts which depended on X11 on Mac OS. There's no explanation given in the pull request. In any case, many people install plan9port on Darwin specifically to use the UI components. Aside from this, the derivation was broken on Mac OS, probably because people put the `which` and `perl` dependencies inside the !isDarwin conditional. Some programs worked, however the static libraries did not build, so this could not be used as a buildInput to build programs which need the libraries. This fixes that.
eraserhd
force-pushed
the
plan9port-enable-darwin-x11
branch
from
05991ec
to
26aef37
Compare
|
I just amended the commit with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A commit in 2014 (see #2266) disabled building parts which depended on X11 on Mac OS. There's no explanation given in the pull request. In any case, many people install plan9port on Darwin specifically to use the UI components.
Aside from this, the derivation was broken on Mac OS, probably because people put the
whichandperldependencies inside the !isDarwin conditional. Some programs worked, however the static libraries did not build, so this could not be used as a buildInput to build programswhich need the libraries. This fixes that.
Motivation for this change
Specifically experienced on Mac OS:
$out/plan9/bin/rcwas missing.$out/plan9/lib/lib*.awas missing, preventing9lfrom working.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/) (see note)nix path-info -Sbefore and after)There's a lot of binaries, so I didn't run them all. I did test the things that I needed that were missing on Mac OS (
rcand9l), and they work.nix-reviewreported that no packages were built.This should be safe.