Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.FileSlurp: 9999.25 -> 9999.26 #57977

Closed
wants to merge 1 commit into from
Closed

perlPackages.FileSlurp: 9999.25 -> 9999.26 #57977

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 20, 2019 •
edited

Motivation for this change

https://metacpan.org/source/CAPOEIRAB/File-Slurp-9999.26/Changes
No longer uses syswrite, so patch is dropped (and expression regenerated from cpan generator)
Fixes usage with perldevel

Candidate for backport (though this only affects perldevelPackages, I think.) cc #56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb closed this Mar 22, 2019
@srhb srhb deleted the FileSlurp branch March 22, 2019 19:03
@samueldr
Copy link
Member

samueldr commented Mar 30, 2019 •
edited

We do not have the equivalent upgrade in staging-19.03. @volth can you provide guidance in the better way to handle updating File-Slurp for 19.03? Thank you!

(Is it as simple as to wait staging merges in master, and then backport those specific upgrades to staging-19.03 once merged?)

@samueldr samueldr mentioned this pull request Mar 30, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @samueldr @GrahamcOfBorg