Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opl3bankeditor: 2019-01-12 -> 1.5 #57976

Merged
merged 1 commit into from Mar 27, 2019
Merged

opl3bankeditor: 2019-01-12 -> 1.5 #57976

merged 1 commit into from Mar 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 20, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 23, 2019

@GrahamcOfBorg build opl3bankeditor

@ryantm ryantm merged commit 024fd02 into NixOS:master Mar 27, 2019
@ghost
Copy link
Author

ghost commented Mar 27, 2019

@ryantm Thank you!

@ghost ghost deleted the opl3bankeditor branch March 27, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryantm @GrahamcOfBorg