Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages: multiple fixes #58035

Merged
merged 7 commits into from Mar 22, 2019
Merged

pythonPackages: multiple fixes #58035

merged 7 commits into from Mar 22, 2019

Conversation

dotlambda
Copy link
Member

Motivation for this change

#56826

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 21, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner March 21, 2019 12:08
dotlambda referenced this pull request Mar 21, 2019
@peti
python-suds-jurko: disable the test suite
c103b5b 
The test suite was broken by ee38a0d.
worldofpeace
worldofpeace reviewed Mar 21, 2019
View reviewed changes
pkgs/development/python-modules/pytest-server-fixtures/default.nix
@@ -11,8 +11,8 @@ buildPythonPackage rec {
sha256 = "c89f9532f62cf851489082ece1ec692b6ed5b0f88f20823bea25e2a963ebee8f";
};

buildInputs = [ pytest ];
propagatedBuildInputs = [ setuptools-git pytest-shutil pytest-fixture-config psutil requests future ];
buildInputs = [ pytest_3 ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just add this as a patch man-group/pytest-plugins@abffd67 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's more of a hassle than it's worth because we'd have to vendor the patch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, though they did say there would be a release soon man-group/pytest-plugins#125 (comment).

This should be fine for now.

@dotlambda dotlambda merged commit 22bb090 into NixOS:master Mar 22, 2019
@dotlambda dotlambda deleted the python-fixes branch March 22, 2019 10:02
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@FRidh FRidh Awaiting requested review from FRidh

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @worldofpeace @samueldr @GrahamcOfBorg