Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the hide/show status of windows persistent #2102

Merged
merged 6 commits into from
Mar 22, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 21, 2019

  • Move the hide/show bit to WindowRenderer and save/load it.
  • Add Hide, Show, Shown and Toggle to manage that bit.
  • Make RenderWindow nonabstract to factor out logic that's common to all the windows (e.g., clearing the lock when hiding).
  • Subclasses are now expected to override Title and a new RenderWindow(int) method.
  • Pass GUI options at construction if needed with a reasonable default.
  • Drudgery to centre a window the first time it is shown.

@@ -679,12 +675,11 @@ private enum UnityLayers {
private void OnGUI() {
if (is_bad_installation_) {
bad_installation_dialog_.Show();
bad_installation_dialog_.RenderWindow();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the show_ bit equivalent to the window being shown.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Mar 22, 2019
@pleroy pleroy merged commit e0596af into mockingbirdnest:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants