Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifiStable: 5.10.19 -> 5.10.20 #57989

Closed
wants to merge 2 commits into from
Closed

unifiStable: 5.10.19 -> 5.10.20 #57989

wants to merge 2 commits into from

Conversation

bachp
Copy link
Member

@bachp bachp commented Mar 20, 2019 •
edited

Motivation for this change

Update the unifi package to the latest stable version.

As discussed in #56992 replace @erictapen as maintainer by @bachp and @0x4A6F.
I will have a look at the unifi service later and probably submit a separate PR to take over maintainership there too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bachp
Copy link
Member Author

bachp commented Apr 6, 2019

@0x4A6F I stoped using unifi for the moment. So it makes no sense for me to become a maintainer. In the future this might change again but in the meantim I added you as the maintainer.

@aanderse
Copy link
Member

The version has been bumped to 5.10.23 in master. @0x4A6F if you would still like to be listed as maintainer please open a separate PR.

Thanks!

@aanderse aanderse closed this May 12, 2019
@bachp bachp deleted the unifi-5.10.20 branch May 12, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F left review comments

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bachp @aanderse @0x4A6F @infinisil @GrahamcOfBorg