Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildbot: 1.8.1 -> 2.1.0 #57988

Merged
merged 2 commits into from
Mar 24, 2019
Merged

buildbot: 1.8.1 -> 2.1.0 #57988

merged 2 commits into from
Mar 24, 2019
+162 −132

Conversation

lopsided98
Copy link
Contributor

Things done

Updates buildbot to the latest version. This drops support for Python 2.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Mar 20, 2019
veprbl
veprbl reviewed Mar 21, 2019
View reviewed changes
@veprbl
Copy link
Member

veprbl commented Mar 21, 2019

cc @ryansydnor @nand0p

@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 21, 2019
@lopsided98
buildbot: 1.8.1 -> 2.1.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b2e11e0
@lopsided98
buildbot: remove deprecated aliases
69f2787
@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

@GrahamcOfBorg test buildbot

@veprbl
Copy link
Member

veprbl commented Mar 23, 2019

failed on x86_64 during build
https://logs.nix.ci/?key=nixos/nixpkgs.57988&attempt_id=3d062703-a942-4297-99eb-3334a44a6c0d
succeeded on aarch64
https://logs.nix.ci/?key=nixos/nixpkgs.57988&attempt_id=e493ceeb-c8e3-4df5-9935-5edee8ecedf9

Let's give it another spin:
@GrahamcOfBorg test buildbot

veprbl
veprbl approved these changes Mar 23, 2019
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW it builds/passes test locally on x86_64

@veprbl veprbl merged commit 6f95ac3 into NixOS:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda

@veprbl veprbl

@FRidh FRidh

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @veprbl @dotlambda @GrahamcOfBorg