Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring-plugins: compile missing mysql, ldap, dig, procs, and dbi executables #57973

Merged
merged 5 commits into from May 14, 2019
Merged

monitoring-plugins: compile missing mysql, ldap, dig, procs, and dbi executables #57973

merged 5 commits into from May 14, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 20, 2019 •
edited

Motivation for this change

#57919

I haven't actually confirmed the new binaries perform as expected, but I did run them all with the --help flag and they executed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

@thoughtpolice @relrod does this look good to you?

@relrod
Copy link
Contributor

relrod commented Mar 26, 2019

@aanderse I've unfortunately been out of the nixos loop for some time (I'll get back into it at some point), so I'm the wrong person to ask right now. :(

@thoughtpolice
Copy link
Member

This looks alright to me, though I'm not using any of this infrastructure anymore, myself.

@thoughtpolice thoughtpolice merged commit 5e0a686 into NixOS:master May 14, 2019
@aanderse
Copy link
Member Author

Thanks!

@aanderse aanderse deleted the monitoring-plugins branch May 14, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aanderse @relrod @thoughtpolice @GrahamcOfBorg