Redshift add early startup option, rewrite to use toINI and add more options #57975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaverdh
force-pushed
the
redshift-early-startup
branch
6 times, most recently
from
50ea77f
to
9666364
Compare
xaverdh
changed the title
xaverdh
force-pushed
the
redshift-early-startup
branch
from
516be57
to
e5f880b
Compare
10 tasks
xaverdh
force-pushed
the
redshift-early-startup
branch
from
257616b
to
81e39a1
Compare
|
For the author, reviewers, and committers: this PR was scanned and appears to add a use of the deprecated
|
Lassulus
reviewed
Oct 2, 2019
| @@ -94,6 +123,15 @@ in { | |||
| ''; | |||
| }; | |||
|
|
|||
| extraConfig = mkOption { | |||
| type = types.attrsOf types.string; | |||
There was a problem hiding this comment.
Suggested change
| type = types.attrsOf types.string; | |
| type = types.attrsOf types.lines; |
|
I think we can close this for #50979, which is being worked on again and overall more finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This adds an earlyStartup option, which allows to start redshift before the graphical interface is up.
While doing this, I realized that this can be done a lot simpler using toINI.
This is meant to solve #57961