Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron{,-3}: 2019-03 updates #57935

Merged
merged 4 commits into from Mar 27, 2019
Merged

electron{,-3}: 2019-03 updates #57935

merged 4 commits into from Mar 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 20, 2019

Motivation for this change

(not that monthly is the desired update frequency,
just happens to have been about that for me :))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

@GrahamcOfBorg build electron electron_3

@dtzWill
Copy link
Member Author

dtzWill commented Mar 25, 2019

Anyone know if aarch64 is a new failure?

@dtzWill
Copy link
Member Author

dtzWill commented Mar 26, 2019

aarch64-linux failure is not new, at least it was failing with previous bump: #56799

@dtzWill dtzWill merged commit 7f583df into NixOS:master Mar 27, 2019
@dtzWill dtzWill deleted the update/electron-2019-03 branch March 27, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg