Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngrok-2: use updateScript #57914

Merged
merged 3 commits into from Mar 19, 2019
Merged

ngrok-2: use updateScript #57914

merged 3 commits into from Mar 19, 2019

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Mar 19, 2019 •
edited

Currently ngrok-2 does include a update script, but it is not set in updateScript, so it is not compatible with maintainers/scripts/update.nix.

With this PR it is possible to use:

nix-shell maintainers/scripts/update.nix --argstr package ngrok-2

Resolves #57898

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobvanderlinden
Copy link
Member Author

Ping @roberth

@roberth roberth merged commit 9dd9769 into NixOS:master Mar 19, 2019
@roberth
Copy link
Member

roberth commented Mar 19, 2019

Much nicer!

@bobvanderlinden bobvanderlinden deleted the ngrok2-update-script branch March 19, 2019 20:45
@bobvanderlinden
Copy link
Member Author

Thanks for the merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bobvanderlinden @roberth @GrahamcOfBorg