nsq: 0.3.5 -> 1.1.0, add nixos/nsq #57913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Take a look at NixOS/rfcs#42. With the approach described there, the implementation of this will be simplified and also get correct merging behavior ( |
flokli
reviewed
Mar 28, 2019
| @@ -339,6 +339,7 @@ | |||
| rss2email = 312; | |||
| cockroachdb = 313; | |||
| zoneminder = 314; | |||
| nsq = 315; | |||
There was a problem hiding this comment.
I guess we can avoid allocating a user, by using the DynamicUser feature of systemd.
There was a problem hiding this comment.
And if DynamicUser doesn't work, just a normal user without a static uid will work too
flokli
reviewed
Mar 28, 2019
| # Configuration for nsqd as a Nix attrset: | ||
| nsqdConfig = recursiveUpdate { | ||
| mem_queue_size = cfg.nsqd.queueSize; | ||
| data_path = "${cfg.dataDir}/nsqd"; |
There was a problem hiding this comment.
This would be /var/lib/nsqd.
| wantedBy = [ "multi-user.target" ]; | ||
| serviceConfig.User = cfg.user; | ||
| serviceConfig.Group = cfg.group; | ||
| serviceConfig.PermissionsStartOnly = true; |
There was a problem hiding this comment.
we can drop this, and let systemd handle creation of the state directory.
|
Turns out that I'm not going to need NSQ in NixOS right now. I'll revisit this in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade nsq to the latest release and create a NixOS module for it.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)