Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ir-standard-fonts: init at d36727d #57943

Merged
merged 2 commits into from Apr 8, 2019
Merged

ir-standard-fonts: init at d36727d #57943

merged 2 commits into from Apr 8, 2019

Conversation

LinArcX
Copy link
Contributor

@LinArcX LinArcX commented Mar 20, 2019 •
edited

Motivation for this change

Basic fonts for persian users.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

rycee
rycee reviewed Mar 30, 2019
View reviewed changes
pkgs/data/fonts/ir-standard-fonts/default.nix
};

installPhase = ''
mkdir -p $out/share/fonts/ir-standard-fonts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fonts should go into $out/share/fonts/truetype:

Suggested change
mkdir -p $out/share/fonts/ir-standard-fonts
mkdir -p $out/share/fonts/truetype

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

rycee
rycee reviewed Mar 30, 2019
View reviewed changes
pkgs/data/fonts/ir-standard-fonts/default.nix

installPhase = ''
mkdir -p $out/share/fonts/ir-standard-fonts
cp -v $( find . -name '*.ttf') $out/share/fonts/ir-standard-fonts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cp -v $( find . -name '*.ttf') $out/share/fonts/ir-standard-fonts
cp -v $( find . -name '*.ttf') $out/share/fonts/truetype

@veprbl veprbl merged commit ae3be1a into NixOS:master Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

@rycee rycee rycee left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@LinArcX @samueldr @rycee @veprbl @GrahamcOfBorg