@jwiegley does this look good?

@GrahamcOfBorg build smlnjBootstrap

@vaibhavsagar are you able to address the build failure?

/nix/store/4ixxl0jdcq0zz7xbzmrqg2cpg1wpsi63-stdenv-darwin/setup: line 1317: /usr/bin/xar: Operation not permitted

Unfortunately I don't have access to a Mac.

@vaibhavsagar alright thanks.

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/1

I have to assume the build failure is due to sandboxing preventing access to /usr/bin/xar.

The following appears to fix this for me:

diff --git a/pkgs/development/compilers/smlnj/bootstrap.nix b/pkgs/development/compilers/smlnj/bootstrap.nix
index 2315ae28431..28f65d3ad9d 100644
--- a/pkgs/development/compilers/smlnj/bootstrap.nix
+++ b/pkgs/development/compilers/smlnj/bootstrap.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, cpio, rsync, makeWrapper }:
+{ stdenv, fetchurl, cpio, rsync, xar, makeWrapper }:
 
 stdenv.mkDerivation rec {
   name = "smlnj-bootstrap-${version}";
@@ -13,7 +13,7 @@ stdenv.mkDerivation rec {
   buildInputs = [ cpio rsync makeWrapper ];
 
   unpackPhase = ''
-    /usr/bin/xar -xf $src
+    ${xar}/bin/xar -xf $src
     cd smlnj.pkg
   '';
 

Thanks @lilyball!

@vaibhavsagar I believe nixpkgs guidelines says you should squash the two commits together.

I went ahead and did this, but I don't see it in the guidelines as it's not a typo or whitespace-only change: https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches.

@GrahamcOfBorg build smlnjBootstrap

Thanks for your never ending awesomeness @lilyball!

@vaibhavsagar Oops... it appears this has sat long enough it is out of date. Maybe you should rename this PR and rewrite thebump commit to the newest version.

@aanderse updated.

@GrahamcOfBorg build smlnjBootstrap