Skip to content

alsa-{oss,tools}: 1.1.6 -> 1.1.8 #57918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2019
Merged

alsa-{oss,tools}: 1.1.6 -> 1.1.8 #57918

merged 4 commits into from
Apr 12, 2019
+11 −5

Conversation

bobvanderlinden
Copy link
Member

@bobvanderlinden bobvanderlinden commented Mar 19, 2019 •
edited
Loading

Motivation for this change

alsa-oss and alsa-tools were outdated. They were probably outdated because the version was not a variable that automated updaters could pick up.

This PR also separates version from name and updates the version.

EDIT: In the meantime alsa-oss was updated to 1.1.8. There is no version bump for this package in this PR, but this PR does split name from version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 19, 2019
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Mar 30, 2019
@veprbl
Copy link
Member

veprbl commented Apr 11, 2019

@GrahamcOfBorg build alsaOss alsaPlugins alsaPluginWrapper mar1d

@veprbl
Copy link
Member

veprbl commented Apr 11, 2019

@GrahamcOfBorg build alsaOss alsaPlugins alsaPluginWrapper mar1d

@veprbl veprbl merged commit 1fc591f into NixOS:master Apr 12, 2019
@bobvanderlinden bobvanderlinden deleted the alsa-oss-tools-1.1.8 branch April 13, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl

Assignees
No one assigned
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bobvanderlinden @veprbl @infinisil @GrahamcOfBorg