Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.invoke: patch the default bash path #57908

Merged
merged 1 commit into from Mar 19, 2019
Merged

pythonPackages.invoke: patch the default bash path #57908

merged 1 commit into from Mar 19, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Mar 19, 2019

Motivation for this change

Use a reasonable default bash path :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm requested a review from FRidh as a code owner March 19, 2019 15:37
@dotlambda dotlambda merged commit 8403965 into NixOS:master Mar 19, 2019
@dotlambda
Copy link
Member

Should we backport this?

@zimbatm
Copy link
Member Author

zimbatm commented Mar 19, 2019

yeah it wouldn't hurt I guess

@zimbatm zimbatm deleted the invoke-bash-path branch March 19, 2019 16:42
@dotlambda
Copy link
Member

done in 85d208e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @dotlambda @GrahamcOfBorg