Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix: replace build utils with host utils in config.nix #58104

Closed
wants to merge 1 commit into from
Closed

nix: replace build utils with host utils in config.nix #58104

wants to merge 1 commit into from

Conversation

illegalprime
Copy link
Member

Motivation for this change

When cross-compiling nix build-time deps are saved in config.nix and in profile.d/nix.sh, this will make the correct replacements before install-time to ensure the right dependencies are added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Mar 24, 2019
@matthewbauer matthewbauer mentioned this pull request Mar 28, 2019
Merged
@doronbehar
Copy link
Contributor

@illegalprime Could you have a look at the merge conflicts?

@doronbehar
Copy link
Contributor

Closing as OP seems unmotivated to fix merge conflicts so perhaps the issue this PR originally solved was fixed at NixOS/nix#2748 .

@doronbehar doronbehar closed this May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@illegalprime @doronbehar @veprbl @GrahamcOfBorg