Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGo112Package: fix the function #58105

Merged
merged 1 commit into from Mar 22, 2019
Merged

buildGo112Package: fix the function #58105

merged 1 commit into from Mar 22, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 22, 2019 •
edited

Motivation for this change

The function buildGo112Package was pointing to the wrong path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit changed the base branch from master to staging March 22, 2019 03:54
@kalbasit kalbasit changed the base branch from staging to master March 22, 2019 04:02
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment labels Mar 22, 2019
@kalbasit kalbasit changed the base branch from master to staging March 22, 2019 04:40
@kalbasit kalbasit changed the title buildGoPackage: use go_1_12 instead of go_1_11 buildGo112Package: fix the function Mar 22, 2019
@kalbasit kalbasit merged commit 043255c into NixOS:staging Mar 22, 2019
@kalbasit kalbasit deleted the morph_use-build-go-package branch March 22, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @GrahamcOfBorg