Skip to content

buildGo112Package: fix the function #58105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

buildGo112Package: fix the function #58105

merged 1 commit into from
Mar 22, 2019
+1 −1

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 22, 2019 •
edited
Loading

Motivation for this change

The function buildGo112Package was pointing to the wrong path.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@kalbasit kalbasit changed the base branch from master to staging March 22, 2019 03:54
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 22, 2019
@kalbasit kalbasit changed the base branch from staging to master March 22, 2019 04:02
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: emacs Text editor 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment labels Mar 22, 2019
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 22, 2019
@kalbasit kalbasit changed the base branch from master to staging March 22, 2019 04:40
@kalbasit kalbasit force-pushed the morph_use-build-go-package branch from 4ed6974 to 818df1a Compare March 22, 2019 04:47
@kalbasit kalbasit changed the title buildGoPackage: use go_1_12 instead of go_1_11 buildGo112Package: fix the function Mar 22, 2019
@kalbasit
buildGo112Package: fix the function

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
722226f
@kalbasit kalbasit force-pushed the morph_use-build-go-package branch from 818df1a to 722226f Compare March 22, 2019 04:58
@kalbasit kalbasit merged commit 043255c into NixOS:staging Mar 22, 2019
@kalbasit kalbasit deleted the morph_use-build-go-package branch March 22, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @GrahamcOfBorg