Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule: use go_1_12 instead of go_1_11 #58103

Merged
merged 1 commit into from Mar 22, 2019
Merged

buildGoModule: use go_1_12 instead of go_1_11 #58103

merged 1 commit into from Mar 22, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 22, 2019 •
edited

Motivation for this change

buildGoModule is currently using go_1_11, but the default Go is set to go_1_12. I discovered this inconsistency while working on DBCDK/morph#53

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit
Copy link
Member Author

@GrahamcOfBorg build antibody gitAndTools.lab gotools hetzner-kube hugo jx miniflux mod pet terminal-parrot todoist

@kalbasit kalbasit merged commit 52dae14 into NixOS:master Mar 22, 2019
@kalbasit kalbasit deleted the nixpkgs_update-build-go-module branch March 22, 2019 03:40
kalbasit added a commit to kalbasit/nixpkgs that referenced this pull request Mar 22, 2019
@kalbasit
Merge remote-tracking branch 'origin/master' into staging
5af0780 
* origin/master: (693 commits)
  buildGoModule: use go_1_12 instead of go_1_11 (NixOS#58103)
  gitAndTools.lab: 0.15.2 -> 0.15.3 (NixOS#58091)
  signal-desktop: 1.22.0 -> 1.23.0
  added missing semicolon to documentation
  terminus_font_ttf: 4.46.0 -> 4.47.0
  buildGoModule: remove SSL env vars in favor of cacert in buildInputs (NixOS#58071)
  dav1d: init at 0.2.1
  dropbox-cli: 2018.11.28 -> 2019.02.14
  atlassian-confluence: 6.14.1 -> 6.14.2
  maintainers: update email for dywedir
  python.pkgs.hglib: use patch to specify hg path (NixOS#57926)
  chkrootkit: 0.52 -> 0.53
  radare2-cutter: 1.7.2 -> 1.8.0
  autorandr: 1.7 -> 1.8
  pythonPackages.pyhepmc: fix build
  llvm-polly/clang-polly: use latest llvm
  apulse: 0.1.11.1 -> 0.1.12, cleanup
  factorio: experimental 0.17.14 → 0.17.16 (NixOS#58000)
  sequeler: 0.6.7 -> 0.6.8
  nasc: 0.5.1 -> 0.5.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @GrahamcOfBorg