Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibcLocales: also build C.UTF-8 #58009

Merged
merged 1 commit into from Mar 21, 2019
Merged

glibcLocales: also build C.UTF-8 #58009

merged 1 commit into from Mar 21, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 21, 2019 •
edited

Previously we only build C.UTF-8 as part of the locale-archive
that comes with the glibc core package.
However for consistent use of LANG=C.UTF-8 we also want support
in our glibcLocales as well.
fixes #57974

Tested with:

$ nix-shell -p glibcLocales
$ echo $LOCALE_ARCHIVE
/nix/store/i5zccmsnirxqlx48g4d2r960zawfzzsh-glibc-locales-2.27/lib/locale/locale-archive
$ python3 -c 'import locale; locale.setlocale(locale.LC_ALL, "C.UTF-8")'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
glibcLocales: also build C.UTF-8
467f0f9 
Previously we only build C.UTF-8 as part of the locale-archive
that comes with the glibc core package.
However for consistent use of LANG=C.UTF-8 we also want support
in our glibcLocales as well.
fixes NixOS#57974
@Mic92
Copy link
Member Author

Mic92 commented Mar 21, 2019 •
edited

This is a rather simple change but would make live a lot easier when using python.
Therefore I would also backport this to 19.03.

@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 21, 2019
@Mic92 Mic92 mentioned this pull request Mar 21, 2019
Closed
@Mic92 Mic92 merged commit 7957a93 into NixOS:staging Mar 21, 2019
@Mic92 Mic92 deleted the locales branch March 21, 2019 09:40
@Mic92
Copy link
Member Author

Mic92 commented Mar 21, 2019

Backport to staging-19.03:

[detached HEAD 1db1951] glibcLocales: also build C.UTF-8
Date: Thu Mar 21 06:23:40 2019 +0000
1 file changed, 2 insertions(+)
Press Enter to continue
tig upstream/staging 6.14s user 0.50s system 72% cpu 9.200 total

@bb010g bb010g mentioned this pull request Apr 6, 2019
Closed
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
@matthewbauer matthewbauer mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @samueldr @GrahamcOfBorg