Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyhepmc: fix build #58003

Merged
merged 1 commit into from Mar 21, 2019
Merged

pythonPackages.pyhepmc: fix build #58003

merged 1 commit into from Mar 21, 2019

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 21, 2019

Motivation for this change

Fixes build after 03fb642

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 21, 2019
@veprbl veprbl requested a review from FRidh as a code owner March 21, 2019 04:50
@veprbl
Copy link
Member Author

veprbl commented Mar 21, 2019

@GrahamcOfBorg build python2Packages.pyhepmc

@Mic92
Copy link
Member

Mic92 commented Mar 21, 2019

@GrahamcOfBorg build pythonPackages.pyhepmc

@Mic92 Mic92 merged commit 6b5c285 into NixOS:master Mar 21, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 21, 2019

backport:

[detached HEAD b81f43c] pythonPackages.pyhepmc: fix build
Author: Dmitry Kalinkin dmitry.kalinkin@gmail.com
Date: Thu Mar 21 00:46:22 2019 -0400
1 file changed, 15 insertions(+), 2 deletions(-)

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
@veprbl veprbl deleted the pr/pyhepmc_fix branch December 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @Mic92 @samueldr @GrahamcOfBorg