Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gecko Bug 1529537] Make all font-metrics-affecting properties cascade early. #16000

Merged
merged 1 commit into from May 14, 2019
Merged

[Gecko Bug 1529537] Make all font-metrics-affecting properties cascade early. #16000

merged 1 commit into from May 14, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

And make font-size computation work on the whole font of the parent, not just
accounting for the parent's font-size.

Differential Revision: https://phabricator.services.mozilla.com/D20656

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1529537
gecko-commit: ab48d59e80c28d0a196e6d46bc572f6cfdb6bc95
gecko-integration-branch: central
gecko-reviewers: heycam

wpt-pr-bot
wpt-pr-bot approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@jgraham jgraham closed this Apr 25, 2019
@jgraham jgraham reopened this Apr 25, 2019
@jgraham jgraham closed this Apr 25, 2019
@jgraham jgraham reopened this Apr 25, 2019
@Hexcles Hexcles closed this Apr 26, 2019
@Hexcles Hexcles reopened this Apr 26, 2019
@emilio @jgraham
Make all font-metrics-affecting properties cascade early.
4acf904 
And make font-size computation work on the whole font of the parent, not just
accounting for the parent's font-size.

Differential Revision: https://phabricator.services.mozilla.com/D20656

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1529537
gecko-commit: ab48d59e80c28d0a196e6d46bc572f6cfdb6bc95
gecko-integration-branch: central
gecko-reviewers: heycam
@jgraham jgraham merged commit 4680861 into master May 14, 2019
@gsnedders gsnedders deleted the gecko/1529537 branch September 10, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wpt-pr-bot wpt-pr-bot wpt-pr-bot approved these changes

Assignees
No one assigned
Labels
css-values mozilla:gecko-sync wg-css
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@moz-wptsync-bot @wpt-pr-bot @jgraham @Hexcles @emilio