Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_{7,8}.compiler-rt: update crtbegin-and-end.patch #57980

Merged
merged 1 commit into from Mar 21, 2019
Merged

llvmPackages_{7,8}.compiler-rt: update crtbegin-and-end.patch #57980

merged 1 commit into from Mar 21, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 20, 2019

Motivation for this change

Minor changes after review, see linked page for discussion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
llvmPackages_{7,8}.compiler-rt: update crtbegin-and-end.patch
1cca46a 
Minor changes after review, see linked page for discussion.
@matthewbauer
Copy link
Member

Could you try using the upstream patch from here: https://reviews.llvm.org/D28791

The PR was updated to use stdint.h instead of inttypes.h which was the only difference

@matthewbauer
Copy link
Member

But this all looks good! I think we can WASM support merged soon

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

I believe this IS the patch from your link? Is it not?

@matthewbauer
Copy link
Member

Oh ok. I was just thinking you could use fetchpatch here.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2019

I don't think there's a way to get a stable patch from phabricator, unfortunately.

@dtzWill dtzWill merged commit baa62d9 into NixOS:master Mar 21, 2019
@dtzWill dtzWill deleted the update/compilerrt-crtbegin-patch branch March 21, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @matthewbauer @GrahamcOfBorg