New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr-tools: init at 3.0.0 #57901
adr-tools: init at 3.0.0 #57901
Conversation
2bb3c44
to
cf4cc59
Compare
I addressed @nlewo's requests. Also the tests are running now since 47aa0c1, which is good, as it helped me discover missing dependencies for some subcommands. |
There are still issues with some of the commands though, which have to be fixed. |
I had almost forgotten this PR… anyway, I have checked the issues and I believe this is an upstream problem about missing usage information on I have squashed the commits and rebased to current master, seems to work fine. Ready to merge from my point of view. |
@GrahamcOfBorg build adr-tools |
propagatedBuildInputs = [ getopt bashInteractive ]; | ||
|
||
buildPhase = '' | ||
patchShebangs src/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this done automatically, or is this needed for the check phase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests fail without this buildPhase. They should though as the shebangs will still read #!/bin/bash
afterwards. So it seems it is not done automatically.
doCheck = true; | ||
|
||
checkPhase = '' | ||
make check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does say so in the docs, but when I leave it out, the tests do not run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
Closing this, as I no longer have a need for this tool and the upstream repository looks unmaintained. |
Motivation for this change
adr-tools is a useful command-line utility for working with architecture decision records. This PR adds it to nixpkgs.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)